[PATCH weston v2 4/6] tests: Add test for pointer axis events

Alexandros Frantzis alexandros.frantzis at collabora.com
Mon Dec 18 10:19:10 UTC 2017


On Mon, Dec 18, 2017 at 11:53:24AM +0200, Pekka Paalanen wrote:
> On Wed, 13 Dec 2017 13:27:56 +0200
> Alexandros Frantzis <alexandros.frantzis at collabora.com> wrote:
> 
> > Add test to verify the server correctly emits pointer axis events.  This
> > requires updating the weston-test protocol with a new request for
> > pointer axis events.
> > 
> > Signed-off-by: Alexandros Frantzis <alexandros.frantzis at collabora.com>
> > ---
> > 
> > Changes in v2:
> >  - Add unit suffix "msec" to variables that hold event time.
> > 
> >  protocol/weston-test.xml          |  7 +++++++
> >  tests/pointer-test.c              | 28 ++++++++++++++++++++++++++++
> >  tests/weston-test-client-helper.c | 17 ++++++++++++++---
> >  tests/weston-test-client-helper.h |  4 ++++
> >  tests/weston-test.c               | 20 ++++++++++++++++++++
> >  5 files changed, 73 insertions(+), 3 deletions(-)
> 
> > diff --git a/tests/weston-test-client-helper.h b/tests/weston-test-client-helper.h
> > index 6f5f9c41..76f07491 100644
> > --- a/tests/weston-test-client-helper.h
> > +++ b/tests/weston-test-client-helper.h
> > @@ -90,8 +90,12 @@ struct pointer {
> >  	int y;
> >  	uint32_t button;
> >  	uint32_t state;
> > +	uint32_t axis;
> > +	double axis_value;
> >  	uint32_t motion_time_msec;
> >  	uint32_t button_time_msec;
> > +	double axis_time_msec;
> > +	double axis_stop_time_msec;
> 
> Why are these times doubles instead of uint32_t?

A mistake, fixed in v3.

Thanks,
Alexandros


More information about the wayland-devel mailing list