[PATCH wayland v3 03/10] connection: Refactor out closure allocation

Daniel Stone daniel at fooishbar.org
Wed Dec 27 14:08:35 UTC 2017


Hi Derek,

On 6 December 2017 at 17:22, Derek Foreman <derekf at osg.samsung.com> wrote:
> Moves the common/similar bits into one place.
>
> This has a minor functional change - count and message are now initialized
> immediately, previously they'd only be set if (de)marshal was successful.

I've reviewed this does what it says on the box, and the outcome is
correct, so I'm going to land it. But as a drive-by, you could get rid
of some of the local variables like 'count = closure->count', so it's
a little more clear to the casual reader what's going on.

Cheers,
Daniel


More information about the wayland-devel mailing list