[PATCH weston 2/2] ivi-shell: simplfy commit_changes function
Pekka Paalanen
ppaalanen at gmail.com
Mon Feb 6 10:14:06 UTC 2017
On Mon, 30 Jan 2017 13:36:07 +0000
"Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:
> It is a better idea to use one for loop instead
> of using three nested for loops.
>
> We do not need to update the transformation of
> views according to the scenegraph. The important
> thing is that every visible view is updated before
> commit_changes function returns.
>
> The first if statement checks, if the view is on
> the currently rendered scenegraph. The second if
> statement checks, if the view's layer or surface
> is visible. These checks ensure that we do not
> update the transformation matrix of a view, which
> is not visible on the screen.
>
> Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
> ---
> ivi-shell/ivi-layout.c | 39 ++++++++++++++++++++-------------------
> 1 file changed, 20 insertions(+), 19 deletions(-)
Hi,
both are R-b me, and pushed with a little whilespace and spelling fix:
819824d..2779935 master -> master
Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170206/b0123912/attachment-0001.sig>
More information about the wayland-devel
mailing list