[PATCH weston 1/2] compositor-drm: update connectors with connector config

[Pekka Paalanen]

On Thu, 2 Feb 2017 14:06:55 +0000
"Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:

> weston can be started with --connector option to be initialized
> with a particular output. But in the update_outputs this option
> is not considered and output is created for all the available
> connectors. This patch fixes this issue by considering
> the option for connectors in the update_outputs.
> 
> Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
> ---
>  libweston/compositor-drm.c |   11 ++++++++++-
>  1 file changed, 10 insertions(+), 1 deletion(-)

Hi,

I would much rather see the whole --connector option removed than
anything to make it work "better".

This is because the option works by DRM connector IDs, which a) are
very hard to find out and b) not guaranteed to be fixed. So it's really
just a debugging option that has outlived its purpose by five years or
so, IMO. I think it also gives a wrong impression about b).

The modern way of defining connector states is weston.ini with its
[output] sections. We still don't have a way to specify the default
behaviour to "off" instead of "use the default/current mode". If such
an option is needed, I would be happy to see one added to weston.ini
where one could define the default behaviour for outputs not matched by
any named [output] section. Besides, this could be implemented already
with the libweston output configuration API in main.c.

Unfortunately, I consider the removal of --connector option a "major
feature", which means we can't do it anymore on this release cycle.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170206/5053d0f9/attachment.sig>