[PATCH weston 1/2] compositor-drm: update connectors with connector config

Pekka Paalanen ppaalanen at gmail.com
Tue Feb 7 09:38:32 UTC 2017


On Tue, 7 Feb 2017 08:36:59 +0000
"Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:

> Hi,
> 
> I would not mind if connector option is removed in next release.
> I found the issue while I was debugging my hotplug patches for ivi-shell.
> 
> But I also agree with Daniel that my patches are legitimate bugfixes.
> We can merge them this release and remove the option altogether in next release.
> 
> Best regards
> 
> Emre Ucan
> Software Group I (ADITG/SW1)
> 
> > -----Original Message-----
> > From: Pekka Paalanen [mailto:ppaalanen at gmail.com]
> > Sent: Montag, 6. Februar 2017 14:08
> > To: Daniel Stone
> > Cc: Ucan, Emre (ADITG/SW1); wayland-devel at lists.freedesktop.org
> > Subject: Re: [PATCH weston 1/2] compositor-drm: update connectors with
> > connector config
> > 
> > On Mon, 6 Feb 2017 12:19:45 +0000
> > Daniel Stone <daniel at fooishbar.org> wrote:
> >   
> > > Hi Pekka,
> > >
> > > On 6 February 2017 at 12:00, Pekka Paalanen <ppaalanen at gmail.com>  
> > wrote:  
> > > > On Mon, 6 Feb 2017 11:05:51 +0000
> > > > Daniel Stone <daniel at fooishbar.org> wrote:  
> > > >> I think we've got to choose between fixing it for 1.13 and removing it
> > > >> immediately after release (which I will happily do), or just ripping
> > > >> it out now.  
> > > >
> > > > I believe it works already as well as it ever has. Therefore any change
> > > > to how it works is something no user has ever seen before.
> > > >
> > > > I reviewed update_outputs() from Weston 1.10 release (a random pick)
> > > > and it seems that too uses --connector only for start-up, and never for
> > > > hotplug. The same for Weston 1.7, so I believe it has never worked any
> > > > better.
> > > >
> > > > If --connector didn't work *at all* currently, then I'd agree on just
> > > > removing it right now. OTOH, I have seen notes that --connector has
> > > > actually been used in the wild, which is why I'd say it's a major
> > > > feature to remove: it has a risk of user-visible breakage (unknown
> > > > command line option).  
> > >
> > > OK, fair enough. I'd suggest we:
> > >   - merge Emre's two patches as legitimate bugfixes
> > >   - document --connector as deprecated in NEWS for 2.0 (must stop typing  
> > 1.13)  
> > >   - remove it for 2.1 (or 3.0 or whatever)
> > >
> > > How's that sound? For the record, these two patches are:
> > > Acked-by: Daniel Stone <daniels at collabora.com>  
> > 
> > If you want to merge them, that's fine. I just wont bother myself.

Ok, fine, pushed both:
   c889012..9a200d7  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170207/da97ae66/attachment-0001.sig>


More information about the wayland-devel mailing list