[PATCH weston 7/7] compositor: damage pending subsurfaces when committing them

Pekka Paalanen ppaalanen at gmail.com
Tue Feb 7 12:32:00 UTC 2017


On Wed, 1 Feb 2017 11:47:06 -0500
Micah Fedke <micah.fedke at collabora.co.uk> wrote:

> On 01/27/2017 04:30 AM, Emilio Pozuelo Monfort wrote:
> > When a client changes the subsurfaces state, we need to damage
> > them so the result is visible. We do that by flagging the surfaces
> > when the state changes and causing damage when committing the
> > state. This prevents normal repaints from considering these changes
> > until a commit has happened, and allows the client to atomically
> > schedule several changes.
> >
> > This fixes the subsurface_z_order test, which is now marked as expected
> > to succeed.
> >
> > Signed-off-by: Emilio Pozuelo Monfort <emilio.pozuelo at collabora.co.uk>
> > Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > ---
> >  libweston/compositor.c       | 31 +++++++++++++++++++++++++++++++
> >  libweston/compositor.h       |  3 +++
> >  tests/subsurface-shot-test.c |  2 +-
> >  3 files changed, 35 insertions(+), 1 deletion(-)

> 
> This series looks good to me, but note that there may be some room for 
> future optimization in the subsurface damage code above.
> This, and the rest of the series,
> Reviewed-by: Micah Fedke <micah.fedke at collabora.co.uk>

This series is pushed:
   0fee977..19222b4  master -> master

I had to modify patches 1 and 2 to fix a build failure in patch 1, I
implemented Quentin's suggestions, and added one tiny patch on top to
document the test runner a bit.


Thank you all,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170207/05e3bb20/attachment.sig>


More information about the wayland-devel mailing list