[PATCH libinput] touchpad: expand top middle button to cover 40mm to 60mm

Hans de Goede hdegoede at redhat.com
Thu Feb 9 16:13:59 UTC 2017


Hi,

On 08-02-17 01:17, Peter Hutterer wrote:
> 42 and 58 were within the middle button already, 40/60 are more accurate
> values.
>
> https://bugs.freedesktop.org/show_bug.cgi?id=99212
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>

Looks good to me:

Reviewed-by: Hans de Goede <hdegoede at redhat.com>

Regards,

Hans


> ---
>  src/evdev-mt-touchpad-buttons.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/evdev-mt-touchpad-buttons.c b/src/evdev-mt-touchpad-buttons.c
> index 4a68470..b53d2e4 100644
> --- a/src/evdev-mt-touchpad-buttons.c
> +++ b/src/evdev-mt-touchpad-buttons.c
> @@ -610,13 +610,13 @@ tp_init_top_softbuttons(struct tp_dispatch *tp,
>
>  		evdev_device_get_size(device, &width, &height);
>
> -		mm.x = width * 0.58;
> +		mm.x = width * 0.60;
>  		mm.y = topsize_mm;
>  		edges = evdev_device_mm_to_units(device, &mm);
>  		tp->buttons.top_area.bottom_edge = edges.y;
>  		tp->buttons.top_area.rightbutton_left_edge = edges.x;
>
> -		mm.x = width * 0.42;
> +		mm.x = width * 0.40;
>  		edges = evdev_device_mm_to_units(device, &mm);
>  		tp->buttons.top_area.leftbutton_right_edge = edges.x;
>  	} else {
>


More information about the wayland-devel mailing list