[PATCH weston v6] compositor-drm: Ignore non-KMS devices

[Pekka Paalanen]

On Fri, 17 Feb 2017 07:43:24 +0000
"Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:

> Hi Daniel,
> 
> It would be great to have this patch in weston 2.0.
> We made a similar patch to fix this issue for Renesas Gen3 boards.

Hi Emre,

it seems too risky to land now when we are in "release critical bug
fixes only" phase. But it could be possible to have it in 2.0 stable
branch after it has been brewing in master for a while. So aiming for
2.0.1 might be an option.


Thanks,
pq

> > -----Original Message-----
> > From: wayland-devel [mailto:wayland-devel-
> > bounces at lists.freedesktop.org] On Behalf Of Daniel Stone
> > Sent: Dienstag, 14. Februar 2017 17:12
> > To: wayland-devel at lists.freedesktop.org
> > Subject: [PATCH weston v6] compositor-drm: Ignore non-KMS devices
> > 
> > Given that we can have render-only devices, or vgem in a class of its
> > own, ignore any non-KMS devices in compositor-drm's device selection.
> > For x86 platforms, this is mostly a non-issue since we look at the udev
> > boot_vga issue, but other architectures which lack this, and have
> > multiple KMS devices present, will hit this.
> > 
> > Signed-off-by: Daniel Stone <daniels at collabora.com>
> > Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
> > Reported-by: Thierry Reding <treding at nvidia.com>
> > Reported-by: Daniel Vetter <daniel.vetter at intel.com>
> > ---
> >  libweston/compositor-drm.c | 145
> > ++++++++++++++++++++++++++++++++-------------
> >  1 file changed, 103 insertions(+), 42 deletions(-)
> > 
> > This is now R-b, but I'm going to leave it on the list to decide whether
> > or not we should ship it; it's awfully close to release day.
> > 
> > v6: Elaborate comment further. Properly initialise and test for old FD.
> >     Use correct filename in all cases. Don't overwrite 'id' in corner
> >     cases.
> > 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170217/f880288f/attachment.sig>