[PATCH weston] config-parser: Export weston_config_next_section

[Pekka Paalanen]

On Tue, 21 Feb 2017 11:58:20 +0000
Emmanuel Gil Peyrot <emmanuel.peyrot at collabora.com> wrote:

> This symbol wasn’t exported from the weston binary, most likely due to
> an oversight in 6e2c12496bbef3cc913cfe9d5f0aeb4d8b23b368, and because
> internal modules can link against libshared.la directly it hasn’t been
> found ever since.
> 
> This commit makes it possible for external modules to iterate over the
> configuration file.
> 
> Signed-off-by: Emmanuel Gil Peyrot <emmanuel.peyrot at collabora.com>
> ---
>  shared/config-parser.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/shared/config-parser.c b/shared/config-parser.c
> index e2b5fa25..2a595b1f 100644
> --- a/shared/config-parser.c
> +++ b/shared/config-parser.c
> @@ -490,6 +490,7 @@ weston_config_get_full_path(struct weston_config *config)
>  	return config == NULL ? NULL : config->path;
>  }
>  
> +WL_EXPORT
>  int
>  weston_config_next_section(struct weston_config *config,
>  			   struct weston_config_section **section,

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Bryce, this is a low-risk patch which we cannot land in a stable branch
after the release because it adds ABI to libweston and that AFAIU would
require a minor-version bump, but the stable branch only does
patch-version bumps. OTOH, it is not a release critical bug fix IMHO.
You should decide if this goes in for Weston 2.0 or waits for a whole
cycle before being released. I am fine either way, really, but I am
also in a slightly awkward position to make the call (conflict of
interests).

I know Emmanuel has a use case for this function in an out-of-tree
weston plugin.

The whole libweston thing is a little sad: libshared.la gets built into
libweston. config-parser.c exports functions, presumably because they
were necessary to export from weston the executable for plugins to use.
But because of that, libweston also now exports a bunch of functions it
shouldn't really. I filed:
https://phabricator.freedesktop.org/T7713


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170221/00ff14e6/attachment.sig>