[PATCH wayland v2 2/4] wayland-util: split out private functionality to separate file

Eric Engestrom eric.engestrom at imgtec.com
Wed Feb 22 14:44:25 UTC 2017


On Tuesday, 2017-02-21 16:14:27 +0000, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov at collabora.com>
> 
> With next commit we'll make wayland-util a shared library (for reasons
> mentioned in the commit). As such we need to make sure that the private
> symbols are somewhere that they can be used internally. Otherwise we'll
> end up with link errors.
> 
> v2: Rebase.
> 
> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> ---
>  Makefile.am                |   1 +
>  src/wayland-util-private.c | 303 +++++++++++++++++++++++++++++++++++++++++++++
>  src/wayland-util.c         | 272 +---------------------------------------
>  3 files changed, 305 insertions(+), 271 deletions(-)
>  create mode 100644 src/wayland-util-private.c
> 

[snip]

> diff --git a/src/wayland-util.c b/src/wayland-util.c
> index cab7fc5..bb91aa7 100644
> --- a/src/wayland-util.c
> +++ b/src/wayland-util.c
> @@ -30,8 +30,8 @@
>  #include <string.h>
>  #include <stdarg.h>
>  
> -#include "wayland-util.h"
>  #include "wayland-private.h"
> +#include "wayland-util.h"
>  
>  WL_EXPORT void
>  wl_list_init(struct wl_list *list)

Seeing this raises a red flag in my mind: why is this needed?


More information about the wayland-devel mailing list