[PATCH libinput v2 3/5] Add evdev_dispatch interface for lid switch

jye836 at gmail.com jye836 at gmail.com
Sat Jan 14 04:22:14 UTC 2017

On Thu, Jan 12, 2017 at 2:21 PM, Peter Hutterer 
<peter.hutterer at who-t.net> wrote:
> doh. not sure how I missed this in the first one, but this needs an 
> extra
> check for the event code too, otherwise we'll be sending switch lid 
> events
> for any switch on the device.
> We filter for SW_LID but if a device happens to have switch and 
> tablet mode
> on the same node, then we do the wrong thing here. So I'd say, the 
> easiest
> here is have a lid_switch_process_switch() for EV_SW and move that 
> condition
> into a switch() statement in there (similar-ish to what the touchpad 
> code
> does for example).
> I'm also relatively hesitant to merge the tablet mode switch enum 
> value
> unless we have an implementation for it. That's easy to remove though.

I agree with this.  The states I have given it are supposed to be 
with the lid switch, but I don't know if it's different in any actual 
mode switches in the wild.  That being said, it's just as easily added 
as it
is removed, so I'll remove it for now.


> the rest is good now, thanks.
> Cheers,
>    Peter

More information about the wayland-devel mailing list