[PATCH weston v2 01/24] xwayland: WM debug prints

[Quentin Glidic]

On 21/12/2016 15:39, Pekka Paalanen wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> Add WM debug prints on map, decoration drawing and geometry setting.
> These help see the sequence and timing of operations, when debugging
> Xwayland window management glitches.
> 
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Seems good:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>


> ---
>   xwayland/window-manager.c | 10 ++++++++++
>   1 file changed, 10 insertions(+)
> 
> diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
> index 56d65af..1830864 100644
> --- a/xwayland/window-manager.c
> +++ b/xwayland/window-manager.c
> @@ -1050,6 +1050,8 @@ weston_wm_window_draw_decoration(void *data)
>   	uint32_t flags = 0;
>   	struct weston_view *view;
>   
> +	wm_log("XWM: start draw decoration, win %d\n", window->id);
> +
>   	weston_wm_window_read_properties(window);
>   
>   	window->repaint_source = NULL;
> @@ -1108,6 +1110,9 @@ weston_wm_window_draw_decoration(void *data)
>   		pixman_region32_init_rect(&window->surface->pending.input,
>   					  input_x, input_y, input_w, input_h);
>   
> +		wm_log("XWM: draw decoration, win %d geometry: %d,%d %dx%d\n",
> +		       window->id, input_x, input_y, input_w, input_h);
> +
>   		xwayland_interface->set_window_geometry(window->shsurf,
>   							input_x, input_y, input_w, input_h);
>   	}
> @@ -1139,6 +1144,8 @@ weston_wm_window_schedule_repaint(struct weston_wm_window *window)
>   	if (window->repaint_source)
>   		return;
>   
> +	wm_log("XWM: schedule repaint, win %d\n", window->id);
> +
>   	window->repaint_source =
>   		wl_event_loop_add_idle(wm->server->loop,
>   				       weston_wm_window_draw_decoration,
> @@ -2547,6 +2554,9 @@ xserver_map_shell_surface(struct weston_wm_window *window,
>   						   window->surface,
>   						   &shell_client);
>   
> +	wm_log("XWM: map shell surface, win %d, xwayland surface %p\n",
> +	       window->id, window->shsurf);
> +
>   	if (window->name)
>   		xwayland_interface->set_title(window->shsurf, window->name);
>   	if (window->pid > 0)
> 


-- 

Quentin “Sardem FF7” Glidic