[PATCH weston v2 15/24] xwm: postpone geometry dirtying from pending.opaque

[Quentin Glidic]

On 21/12/2016 15:40, Pekka Paalanen wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> Changing the opaque region has no immediate effect, therefore there is
> no need to mark the view geometry dirty.
> 
> The view geometry will be invalidated automatically by the next commit
> from Xwayland, in weston_surface_commit_state(). The dirtying did not
> apply pending state.
> 
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Not sure I fully understand what the code does (or not), but the patch 
looks to fit the commit message:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Thanks,


> ---
>   xwayland/window-manager.c | 6 ------
>   1 file changed, 6 deletions(-)
> 
> diff --git a/xwayland/window-manager.c b/xwayland/window-manager.c
> index 5466bc9..021b18a 100644
> --- a/xwayland/window-manager.c
> +++ b/xwayland/window-manager.c
> @@ -1130,7 +1130,6 @@ weston_wm_window_draw_decoration(void *data)
>   	const struct weston_desktop_xwayland_interface *xwayland_interface =
>   		wm->server->compositor->xwayland_interface;
>   	uint32_t flags = 0;
> -	struct weston_view *view;
>   
>   	wm_log("XWM: start draw decoration, win %d\n", window->id);
>   
> @@ -1175,8 +1174,6 @@ weston_wm_window_draw_decoration(void *data)
>   						  window->width + 2,
>   						  window->height + 2);
>   		}
> -		wl_list_for_each(view, &window->surface->views, surface_link)
> -			weston_view_geometry_dirty(view);
>   
>   		pixman_region32_fini(&window->surface->pending.input);
>   
> @@ -1209,7 +1206,6 @@ static void
>   weston_wm_window_schedule_repaint(struct weston_wm_window *window)
>   {
>   	struct weston_wm *wm = window->wm;
> -	struct weston_view *view;
>   	int width, height;
>   
>   	if (window->frame_id == XCB_WINDOW_NONE) {
> @@ -1227,8 +1223,6 @@ weston_wm_window_schedule_repaint(struct weston_wm_window *window)
>   				pixman_region32_init_rect(&window->surface->pending.opaque, 0, 0,
>   							  width, height);
>   			}
> -			wl_list_for_each(view, &window->surface->views, surface_link)
> -				weston_view_geometry_dirty(view);
>   		}
>   		return;
>   	}
> 


-- 

Quentin “Sardem FF7” Glidic