[PATCH weston 1/2] desktop-shell: Initialise panel surface listener

[Quentin Glidic]

On 16/01/2017 14:23, Daniel Stone wrote:
> The desktop-shell output destroy code assumes that we always set up a
> panel listener. Initialise its list explicitly, so if we don't have a
> panel, then we can still unconditionally destroy the listener on output
> destroy.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>

Good point:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Thanks,


> ---
>   desktop-shell/shell.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/desktop-shell/shell.c b/desktop-shell/shell.c
> index 8388dc3..ce4b870 100644
> --- a/desktop-shell/shell.c
> +++ b/desktop-shell/shell.c
> @@ -4667,6 +4667,7 @@ create_shell_output(struct desktop_shell *shell,
>   	shell_output->output = output;
>   	shell_output->shell = shell;
>   	shell_output->destroy_listener.notify = handle_output_destroy;
> +	wl_list_init(&shell_output->panel_surface_listener.link);
>   	wl_signal_add(&output->destroy_signal,
>   		      &shell_output->destroy_listener);
>   	wl_list_insert(shell->output_list.prev, &shell_output->link);
> 


-- 

Quentin “Sardem FF7” Glidic