[PATCH weston v2] editor: Drop g_type_init() call

Quentin Glidic sardemff7+wayland at sardemff7.net
Mon Jan 16 15:24:24 UTC 2017


On 16/01/2017 14:04, Daniel Stone wrote:
> Hi,
> 
> On 16 January 2017 at 13:01, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> On 15 January 2017 at 12:26, Quentin Glidic
>> <sardemff7+wayland at sardemff7.net> wrote:
>>> -  PKG_CHECK_MODULES(PANGO, [pangocairo], [have_pango=yes], [have_pango=no])
>>> +  PKG_CHECK_MODULES(PANGO, [pangocairo pango glib >= 2.36], [have_pango=yes], [have_pango=no])
>>
>> Afaict there is no upstream glib - perhaps you meant glib-2.0 ? There
>> seems to be a bunch of g_* dependencies outside of libglib-2.0.so,
>> which seems to be missing in configure.
> 
> Indeed, glib.pc is for GLib 1.x; my Fedora version has 1.2.10, so this
> will never trigger. With that fixed (i.e. the dep being on glib-2.0
> instead):
> Reviewed-by: Daniel Stone <daniels at collabora.com>

Oops, I probably mixed my distcheck with some other patch.
Fixed, distchecked and pushed:
46ffea63..db776dbe  master -> master

Thanks,


-- 

Quentin “Sardem FF7” Glidic


More information about the wayland-devel mailing list