[PATCH weston v2 12/24] xwm: move set_title and set_pid

[Pekka Paalanen]

On Sun, 15 Jan 2017 14:52:40 +0100
Quentin Glidic <sardemff7+wayland at sardemff7.net> wrote:

> On 21/12/2016 15:40, Pekka Paalanen wrote:
> > From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > 
> > Move the calls to set_title() and set_pid() out of
> > weston_wm_window_read_properties() and into the three callers, each
> > slightly different.
> > 
> > xserver_map_shell_surface(): already calls these functions after
> > creating the shell surface, so need to add calls.  
> 
> typo: “so need” → “so no need”

Oh yeah!

> > weston_wm_handle_map_request(): can be called only on unmapped (in X11)
> > Windows, so no need to add calls.
> > 
> > weston_wm_window_draw_decoration(): window->shsurf and window->surface
> > are either both set or both NULL, so the check for window->shsurf is
> > removed when moving the set_title() and set_pid() calls under a
> > window->surface check.
> > 
> > Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>  
> 
> Nice cleanup:
> Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Thank you,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170116/482ab09c/attachment-0001.sig>