[PATCH weston v2 00/24] Initial Xwayland window positioning, with XWM reordering

Pekka Paalanen ppaalanen at gmail.com
Tue Jan 17 15:22:48 UTC 2017

On Wed, 21 Dec 2016 16:39:58 +0200
Pekka Paalanen <ppaalanen at gmail.com> wrote:

> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> Hi all,
> for the history and motivation of this series, please refer to:
> https://phabricator.freedesktop.org/T7622
> Most importantly, you can see the introduction and motivation here:
> https://lists.freedesktop.org/archives/wayland-devel/2016-November/031976.html
> This patch series is also available as a branch:
> https://git.collabora.com/cgit/user/pq/weston.git/log/?h=x11-positioning-v2
> In this v2, patches 1-6 are exactly the same as v1. The old patch 7 is
> now patch 24.
> The reason for the new patches 7-23 is the clean-up and the new
> operating sequence called for in T7622. I tried to keep each patch as
> simple and straightforward as possible, hence the number of them.
> I have refactored xwayland/window-manager.c a lot around the window
> MapRequest handling and decoration repainting, hopefully the code is
> now also a little more readable. This was necessary so that the actual
> behavioral changes would not drown in the churn.
> The functionality in the final patch of this series depends on the
> Xwayland series:
> https://patchwork.freedesktop.org/series/16610/
> However, the Xwayland patches are not a requirement - without them
> things should still work, if a bit more glitchy than with.

> Pekka Paalanen (24):
>   xwayland: WM debug prints
>   xwayland: add set_toplevel_with_position to internal API
>   libweston-desktop: add set_xwayland_position API
>   xwayland: detect initially positioned X11 windows
>   shell: implement set_xwayland_position
>   libweston-desktop/xwayland: react to geometry changes
>   desktop-shell: debug set_position_from_xwayland
>   libweston-desktop/xwayland: debug commits
>   xwm: detect legacy fullscreen on MapRequest
>   xwm: clarify props[] in weston_wm_window_read_properties()
>   xwm: move frame_set_title() into draw_decoration()
>   xwm: move set_title and set_pid
>   xwm: debug changes to override-redirect flag
>   xwm: debug print deleted property name
>   xwm: postpone geometry dirtying from pending.opaque
>   xwm: delete dead flags from weston_wm_window_draw_decorations()
>   xwm: split weston_wm_window_draw_decoration()
>   xwm: move fini near init in set_pending_state
>   xwm: split out weston_wm_window_set_pending_state_OR()
>   xwm: schedule repaint from MapRequest
>   xwm: debug when weston_surface gets created
>   xwm: explain the read_properties() in xserver_map_shell_surface()
>   xwm: do not draw decor twice on map
>  desktop-shell/shell.c                  |  43 ++++
>  libweston-desktop/internal.h           |   5 +
>  libweston-desktop/libweston-desktop.c  |  10 +
>  libweston-desktop/libweston-desktop.h  |  33 +++
>  libweston-desktop/xwayland.c           |  22 ++
>  xwayland/window-manager.c              | 397 ++++++++++++++++++++++++---------
>  xwayland/xwayland-internal-interface.h |   2 +
>  xwayland/xwayland.h                    |   1 +
>  8 files changed, 411 insertions(+), 102 deletions(-)


with reviews from Quentin, I have merged 10 patches from this series.
The patches were all prerequisites and trivials.
   b08e1a5..39d7e99  master -> master

You can see the state of the current series at:

And I have a rebased branch at:

In the branch I have squashed "desktop-shell: debug
set_position_from_xwayland" into "shell: implement

Daniel, I think you can skip looking at all patches already R-b
Quentin, except those where the commit message highlights a regression.
I'd like some opinions if the regressions are bad and whether we should
block things for the last patch.

The last patch "xwm: use _XWAYLAND_ALLOW_COMMITS" cannot be merged
until the Xwayland patch adding the feature has been accepted.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170117/a41abefc/attachment.sig>

More information about the wayland-devel mailing list