[PATCH weston v2 00/24] Initial Xwayland window positioning, with XWM reordering

[Pekka Paalanen]

On Wed, 18 Jan 2017 12:17:24 +0000
Daniel Stone <daniel at fooishbar.org> wrote:

> Hi,
> 
> On 18 January 2017 at 12:02, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > On Tue, 17 Jan 2017 15:44:32 +0000
> > Daniel Stone <daniel at fooishbar.org> wrote:  
> >> 'react to geometry changes' makes me a little nervous; is there a way
> >> you can see that this can be resequenced or moved such that we don't
> >> have the intermediate regression?  
> >
> > I think it could be left even as the last patch in the series. In its
> > current point of the series it is needed to make -geometry work, but
> > after the _XWAYLAND_ALLOW_COMMITS support -geometry should work also
> > without it.  
> 
> Nod. I'm just keen to avoid intermediate regressions for people who
> aren't using -geometry, especially if we don't have an ETA for landing
> the _XWAYLAND_ALLOW_COMMITS work.
> 
> >> 'schedule repaint from MapRequest' looks OK for the second hunk, but
> >> the assert added in the first hunk makes the conditional immediately
> >> above it dead code. Oops.  
> >
> > weston_wm_window_create_frame(window) sets window->frame_id, so the
> > assert just reminds us that frame_id is now guaranteed to be set.
> >
> > Suggestions on how to improve it?  
> 
> Yeah, you are indeed right. Maybe just a comment on the assert noting
> that the above call sets it? With that, R-b me and clear to push.

Added a comment, and pushed the two patches:
   be9c7d8..0bbe624  master -> master


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 801 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170118/089df868/attachment.sig>