[PATCH weston v3 0/3] Initial Xwayland window positioning, with XWM reordering
Pekka Paalanen
ppaalanen at gmail.com
Wed Jan 18 13:37:56 UTC 2017
From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
Hi,
having 20 patches from the series already merged, it is time to re-send the
remaining ones rebased.
Previous version with all the references and motivation:
https://lists.freedesktop.org/archives/wayland-devel/2016-December/032443.html
Nothing has changed in the code contents, but the commit messages have been
updated and the patches have been reordered. That had some surprising
consequences.
'libweston-desktop/xwayland: react to geometry changes' is now ordered last,
and has lost all of its old justification, hence I removed Quentin's R-b. The
only justification left for it is to, well, react to changes in geometry, i.e.
if XWM would ever change decorations' size. The patch is no longer necessary
for -geometry option to work, because the two other patches already ensure it
works.
I was surprised to notice that 'xwm: do not draw decor twice on map' fixes the
-geometry option to take decorations into account. I added my analysis in the
commit message.
It might first appear that 'xwm: use _XWAYLAND_ALLOW_COMMITS' is now
unnecessary, but I believe that is more luck than a guarantee. Though, I
haven't analyzed the current code well enough to see if the race cannot happen
anymore, but even so I would think it to be very fragile and prefer to have
_XWAYLAND_ALLOW_COMMITS.
That said, it might make sense to implement NET_WM_SYNC_REQUEST support before
landing _XWAYLAND_ALLOW_COMMITS support in Xwayland, just to see if we need it
or not.
Thanks,
pq
Pekka Paalanen (3):
xwm: do not draw decor twice on map
xwm: use _XWAYLAND_ALLOW_COMMITS
libweston-desktop/xwayland: react to geometry changes
libweston-desktop/xwayland.c | 7 +++++++
xwayland/window-manager.c | 43 +++++++++++++++++++++++++++++++++++++++++--
xwayland/xwayland.h | 1 +
3 files changed, 49 insertions(+), 2 deletions(-)
--
2.10.2
More information about the wayland-devel
mailing list