[PATCH weston 1/4] ivi-shell: don't check view is rendered before adding surface

Ucan, Emre (ADITG/SW1) eucan at de.adit-jv.com
Wed Jan 18 15:25:28 UTC 2017

If a surface is removed from a layer's render order list, but the
changes are not commited. Then, the surface could not be added to the
same layer. Because ivi_view of the surface is still in the render order
list of the layer.

It is not possible to change the order of surfaces in a layer without
clearing and commiting the changes before. This patch fixes this issue.

After this patch, the pending render order list of a layer is always
modified regardless of its active render order list.

Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
 ivi-shell/ivi-layout.c |    2 --
 1 file changed, 2 deletions(-)

diff --git a/ivi-shell/ivi-layout.c b/ivi-shell/ivi-layout.c
index d1cabd0..4634ad7 100644
--- a/ivi-shell/ivi-layout.c
+++ b/ivi-shell/ivi-layout.c
@@ -1801,8 +1801,6 @@ ivi_layout_layer_add_surface(struct ivi_layout_layer *ivilayer,
 	ivi_view = get_ivi_view(ivilayer, addsurf);
 	if (!ivi_view)
 		ivi_view = ivi_view_create(ivilayer, addsurf);
-	else if (ivi_view_is_rendered(ivi_view))
-		return IVI_SUCCEEDED;
 	wl_list_insert(&ivilayer->pending.view_list, &ivi_view->pending_link);

More information about the wayland-devel mailing list