[PATCH weston] clients: fix errno handling
Emilio Pozuelo Monfort
pochu27 at gmail.com
Wed Jan 18 22:58:20 UTC 2017
On 18/01/17 23:21, Peter Hutterer wrote:
> clients/editor.c: In function ‘read_file’:
> clients/editor.c:1578:16: warning: logical ‘or’ applied to non-boolean
> constant [-Wlogical-op]
> errno = errsv || EINVAL;
>
> This works in the shell, but not in C. Introduced in 411ffabbb56b
>
> Signed-off-by: Peter Hutterer <peter.hutterer at who-t.net>
> ---
> Changes to v1:
> - first version didn't return the right errno, whoops :)
S-o-b me.
Cheers,
Emilio
> clients/editor.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/clients/editor.c b/clients/editor.c
> index f1dffe1..a0cc97a 100644
> --- a/clients/editor.c
> +++ b/clients/editor.c
> @@ -1575,7 +1575,7 @@ error:
> if (fin)
> fclose(fin);
> free(buffer);
> - errno = errsv || EINVAL;
> + errno = errsv ? errsv : EINVAL;
>
> return NULL;
> }
>
More information about the wayland-devel
mailing list