[PATCH weston 66/68] compositor-drm: Test plane states before application

[Daniel Stone]

Hi Fabien,

On 19 January 2017 at 10:52, Fabien DESSENNE <fabien.dessenne at st.com> wrote:
> On 09/12/16 20:58, Daniel Stone wrote:
>> @@ -1706,10 +1718,21 @@ drm_output_prepare_scanout_view(struct drm_output_state *output_state,
>>           state->dest_h != (unsigned) output->base.current_mode->height)
>>               goto err;
>>
>> +     if (mode == DRM_OUTPUT_PROPOSE_STATE_PLANES_ONLY)
>> +             return state;
>> +
>> +     ret = drm_output_apply_state(output_state, mode);
>
> "mode" is not the correct parameter (it is an 'enum
> drm_output_propose_state_mode' and drm_output_apply_state expects an
> 'enum drm_output_apply_state_mode mode').
> Use DRM_OUTPUT_APPLY_STATE_TEST instead of mode

Thanks very much for the review. I actually noticed this a couple of
days ago when working on the global-modeset patches and have these
fixed up locally.

Cheers,
Daniel