[PATCH weston 0/2] ivi-shell: simplfy updating properties of views

Ucan, Emre (ADITG/SW1) eucan at de.adit-jv.com
Mon Jan 30 13:36:03 UTC 2017

After Pekka's review of my "ivi-shell: Damage view below after
unmapping" patch. I decided to divide my patch into three patches.

I am sending now two preparation patches which simplifies updating
properties of views. 

The first patch simplfies commit_changes function. We can easily get
ivisurf, ivilayer and iviscreen from an ivi_view. Then, we do not need
to check, if ivi_view's layer is the same as the given ivilayer.

The second patch removes three nested for loops and implements one for
loop instead. In the old implementation, we stepped through the items of
the scenegraph. Therefore, three nested for loop was needed. In the new
implementation, we are stepping through the items of ivi_view list. We
check, if they are on the scenegraph and visible.

I will send a second version of my rejected patch after these patches
are accepted.

Emre Ucan (2):
  ivi-shell: pass only ivi_view to update_prop
  ivi-shell: simplfy commit_changes function

 ivi-shell/ivi-layout.c |   51 +++++++++++++++++++++++-------------------------
 1 file changed, 24 insertions(+), 27 deletions(-)


More information about the wayland-devel mailing list