[PATCH weston v11 10/13] compositor-drm: Use drm_plane for scanout plane

Daniel Stone daniel at fooishbar.org
Tue Jul 18 14:08:59 UTC 2017


Hi,

On 18 July 2017 at 14:14, Daniel Stone <daniels at collabora.com> wrote:
> @@ -1607,14 +1635,29 @@ drm_output_repaint(struct weston_output *output_base,
>  [...]
> +       /* The legacy SetCrtc API doesn't allow us to do scaling, and the
> +        * legacy PageFlip API doesn't allow us to do clipping either. */
> +       assert(scanout_state->src_w ==
> +               (unsigned) (output->base.current_mode->width << 16));
> +       assert(scanout_state->src_h ==
> +               (unsigned) (output->base.current_mode->height << 16));
> +       assert(scanout_state->src_w == scanout_state->dest_w << 16);
> +       assert(scanout_state->src_h == scanout_state->dest_h << 16);

These asserts are wrong; obviously we want to be checking dest_[wh] as
well as src_[wh]. Amended locally.

Cheers,
Daniel


More information about the wayland-devel mailing list