[PATCH v4] Add xdg-output protocol

[Pekka Paalanen]

On Wed, 19 Jul 2017 10:51:41 +0200
Olivier Fourdan <ofourdan at redhat.com> wrote:

> This protocol aims at describing outputs in way which is more in line
> with the concept of an output on desktop oriented systems.
> 
> Some information are more specific to the concept of an output for a
> desktop oriented system and may not make sense in other applications,
> such as IVI systems for example.
> 
> The goal is to gradually move the desktop specific concepts out of the
> core wl_output protocol.
> 
> For now it just features the position and logical size which describe
> the output position and size in the global compositor space.
> 
> Signed-off-by: Olivier Fourdan <ofourdan at redhat.com>
> Reviewed-by: Jonas Ådahl <jadahl at gmail.com>
> Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> ---
>  v2: use "destroy" instead of "release" for destructor
>  v3: adopt a more conventional global factory interface with a
>      get_xdg_output() method, add some clarification and example.
>  v4: Rebase on current master
>      Add major version in interface name as per Pekka's review
>      Add that objects already created are not affected by the manager
>      destroy method.
>      Remove the word "mode" from argument summary for logical_size as
>      per Pekka's review
>      Add A-b Pekka and R-b Jonas following their respective feedback.
> 
>  Makefile.am                                    |   1 +
>  unstable/xdg-output/README                     |   4 +
>  unstable/xdg-output/xdg-output-unstable-v1.xml | 162 +++++++++++++++++++++++++
>  3 files changed, 167 insertions(+)
>  create mode 100644 unstable/xdg-output/README
>  create mode 100644 unstable/xdg-output/xdg-output-unstable-v1.xml

> +  <interface name="zxdg_output_manager_v1" version="1">
> +    <description summary="manage xdg_output objects">
> +      A global factory interface for xdg_output objects.
> +    </description>
> +
> +    <request name="destroy" type="destructor">
> +      <description summary="destroy the xdg_output_manager object">
> +	Using this request a client can tell the server that it is not
> +	going to use the xdg_output_manager object anymore.
> +
> +	Any objects already created through this instance are not affected.
> +      </description>
> +    </request>
> +
> +    <request name="get_xdg_output">
> +      <description summary="create an xdg output from a wl_output">
> +	This creates a new xdg_output object for the given wl_output.
> +      </description>
> +      <arg name="id" type="new_id" interface="zxdg_output"/>

Hi,

you forgot to update the interface name in the arg.

Fixing that, you can upgrade my Acked-by to Reviewed-by. :-)
No need to send v5 for me.

> +      <arg name="output" type="object" interface="wl_output"/>
> +    </request>
> +  </interface>
> +
> +  <interface name="zxdg_output_v1" version="1">


Thanks,
pq