[PATCH wayland 3/3] tests: Add scanner symbol prefix test

Pekka Paalanen ppaalanen at gmail.com
Mon Jul 24 11:20:56 UTC 2017


On Mon,  3 Jul 2017 17:16:46 +0800
Jonas Ådahl <jadahl at gmail.com> wrote:

> Test that it is possible to implement and use an interface with a
> symbol prefix.
> 
> Signed-off-by: Jonas Ådahl <jadahl at gmail.com>
> ---
>  .gitignore                        |   5 ++
>  Makefile.am                       |  30 +++++++-
>  tests/symbol-prefix-test-client.c |  77 ++++++++++++++++++++
>  tests/symbol-prefix-test-server.c | 145 ++++++++++++++++++++++++++++++++++++++
>  4 files changed, 255 insertions(+), 2 deletions(-)
>  create mode 100644 tests/symbol-prefix-test-client.c
>  create mode 100644 tests/symbol-prefix-test-server.c

Hi,

this looks like a nice rudimentary test that prefix-generated files are
usable. I would like to see more though:
- use of same-named but different protocols in the same program
- verbatim text tests added to tests/scanner-test.sh

A slight caveat with the proposed test is that the original unprefixed
symbols are still available via libwayland.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170724/da86d5c0/attachment-0001.sig>


More information about the wayland-devel mailing list