[PATCH weston 2/2] compositor-drm: remove connector option

[Pekka Paalanen]

On Wed, 8 Mar 2017 15:43:18 +0000
"Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:

> Remove the option, because it is hard to use.
> Drm connector ids are hard to reach for users,
> and they can change when kernel or device tree
> is modified.
> 
> If someone wants to enable just one output and
> disable all others, he can set "require-output-config".
> Then, all unconfigured outputs will be disabled
> automatically.
> 
> Signed-off-by: Emre Ucan <eucan at de.adit-jv.com>
> ---
>  compositor/main.c          |    2 --
>  libweston/compositor-drm.c |   12 +-----------
>  libweston/compositor-drm.h |    6 ------
>  man/weston-drm.man         |    5 -----
>  4 files changed, 1 insertion(+), 24 deletions(-)

> diff --git a/libweston/compositor-drm.h b/libweston/compositor-drm.h
> index 0870719..6f37735 100644
> --- a/libweston/compositor-drm.h
> +++ b/libweston/compositor-drm.h
> @@ -98,12 +98,6 @@ weston_drm_output_get_api(struct weston_compositor *compositor)
>  struct weston_drm_backend_config {
>  	struct weston_backend_config base;
>  
> -	/** The connector id of the output to be initialized.
> -	 *
> -	 * A value of 0 will enable all available outputs.
> -	 */
> -	int connector;
> -

Hi,

you are removing a field from struct weston_drm_backend_config,
breaking ABI. This should be accompanied by a bump to
WESTON_DRM_BACKEND_CONFIG_VERSION.

Otherwise the patch looks good, but I managed to look in here too late.
Since it is removing a command line option from Weston, I think this
has to wait a bit more for the next development cycle.

Acked-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170724/b608ee1f/attachment.sig>