[PATCH weston 0/3] remove set_layer/surface_orientation APIs

Teyfel, Michael (ADITG/ESB) mteyfel at de.adit-jv.com
Tue Jul 25 09:36:11 UTC 2017


Hi Pekka, hi Emre,

I send the patch to wayland-devel ML.


Best regards

Michael Teyfel
Engineering Software Base (ADITG/ESB)

Tel. +49 5121 49 6932

-----Original Message-----
From: Ucan, Emre (ADITG/ESB) 
Sent: Montag, 24. Juli 2017 16:52
To: Pekka Paalanen
Cc: wayland-devel at lists.freedesktop.org; Teyfel, Michael (ADITG/ESB)
Subject: RE: [PATCH weston 0/3] remove set_layer/surface_orientation APIs

Hi Pekka,

Genivi moved its wiki pages. This is the new link: https://at.projects.genivi.org/wiki/display/PROJ/Wayland+IVI+Extension+Design.
We will send a patch to update this.

Best regards

Emre Ucan
Engineering Software Base (ADITG/ESB)

Tel. +49 5121 49 6937

> -----Original Message-----
> From: Pekka Paalanen [mailto:ppaalanen at gmail.com]
> Sent: Montag, 24. Juli 2017 12:41
> To: Ucan, Emre (ADITG/ESB)
> Cc: wayland-devel at lists.freedesktop.org
> Subject: Re: [PATCH weston 0/3] remove set_layer/surface_orientation 
> APIs
> 
> On Fri, 3 Mar 2017 14:21:25 +0000
> "Ucan, Emre (ADITG/SW1)" <eucan at de.adit-jv.com> wrote:
> 
> > These APIs are used to rotate the contents of application's buffer. 
> > But they are not needed because an application can rotate its 
> > buffers with set_buffer_transform request of wl_surface interface.
> >
> > Emre Ucan (3):
> >   ivi-shell: remove surface_set_orientation API
> >   ivi-shell: remove layer_set_orientation API
> >   ivi-shell: remove orientation calculation
> >
> >  ivi-shell/ivi-layout-export.h    |   18 ------
> >  ivi-shell/ivi-layout.c           |  126 ++------------------------------------
> >  tests/ivi_layout-internal-test.c |   63 -------------------
> >  tests/ivi_layout-test-plugin.c   |   34 ----------
> >  tests/ivi_layout-test.c          |    2 -
> >  5 files changed, 4 insertions(+), 239 deletions(-)
> >
> 
> Hi,
> 
> these are removing API, which means it breaks the ABI. However, as we 
> added one and removed two function pointers, struct 
> ivi_layout_interface is still smaller than before, so users should 
> catch it easily.
> 
> In patch 3 I added a commit message.
> 
> Therefore R-b me and pushed:
>    3e5303da..57ac260c  master -> master
> 
> 
> Btw. I noticed that the link mentioned in ivi-layout-export.h is now
> broken:
> http://projects.genivi.org/wayland-ivi-extension/layer-manager-apis
> Is there anything to replace it with?
> 
> 
> Thanks,
> pq


More information about the wayland-devel mailing list