[PATCH weston] logind: actually close fd in launcher_logind_close

Derek Foreman derekf at osg.samsung.com
Tue Jul 25 21:17:36 UTC 2017


We still need to close fds passed to us - or we leak quite a few fds
on VC switch.

Regression, originally fixed in 8f5acc2f3a29c3831af4ddd6bed57f703c98dc77
and re-broken in commit 72dea06d7952e3ce8dd8057f7106186da4fa2678
but only for the logind launcher.

Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
---
 libweston/launcher-logind.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/libweston/launcher-logind.c b/libweston/launcher-logind.c
index f10a2831..a069bd4f 100644
--- a/libweston/launcher-logind.c
+++ b/libweston/launcher-logind.c
@@ -216,6 +216,7 @@ launcher_logind_close(struct weston_launcher *launcher, int fd)
 	int r;
 
 	r = fstat(fd, &st);
+	close(fd);
 	if (r < 0) {
 		weston_log("logind: cannot fstat fd: %m\n");
 		return;
-- 
2.13.3



More information about the wayland-devel mailing list