[PATCH wayland 2/3] scanner: Allow adding a prefix to exported symbols

[Pekka Paalanen]

On Wed, 26 Jul 2017 18:39:52 +0800
Jonas Ådahl <jadahl at gmail.com> wrote:

> On Wed, Jul 26, 2017 at 09:28:45AM +0100, Daniel Stone wrote:
> > Hi,
> > 
> > On 25 July 2017 at 10:24, Pekka Paalanen <ppaalanen at gmail.com> wrote:  

> > > Quentin proposed we add a scanner option
> > > --visibility={static|compiler|export}. It would affect all the symbols
> > > exported from the generated .c files as follows:
> > >
> > > - static: the symbols will be static.
> > > - compiler: the symbols will get whatever the default visibility is
> > >   with the compiler, i.e. not explicitly static and not exported
> > > - export: the symbols are exported (this the old behaviour, and will be
> > >   the default)

> > > We are going to need an option to stop the exports anyway, and it seems
> > > like we can piggyback on that solution for the problem underlying the
> > > prefixing proposal as well.  
> > 
> > This sounds really good to me.
> > 
> > Unfortunately, the release just went out last night without waiting
> > for any of these patches (or even pinging to see what their status
> > was?), so I guess we're not able to make xdg-shell stable for another
> > cycle. >:(  
> 
> Well, we can still, just that anyone wanting to implement it in
> parallel to xdg-shell unstable v5 would have to wait.
> 
> > 
> > It's either that or just merge it post-beta anyway - which I wouldn't
> > actually mind to be honest.  
> 
> That's an option too. I don't have any objections really.

I could be ok merging it before the first RC.

So are we sure enough that RC1 will give enough testing for the feature
to be carved in stone?


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170726/06b55f41/attachment.sig>