[PATCH wayland 1/3] Pass input/output files as arguments to wayland-scanner

[Pekka Paalanen]

On Wed, 26 Jul 2017 15:57:19 +0100
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> On 3 July 2017 at 10:16, Jonas Ådahl <jadahl at gmail.com> wrote:
> > When input/output files are passed as arguments to wayland-scanner,
> > instead of using stdin/stdout, warning and error messages will contain
> > the file name, together with line number, of the warning/error. Doing
> > this helps IDEs jump to the correct line.
> >  
> I really like the idea, there is one concern though - some projects do
> invoke wayland_scanner directly in their build system.
> Thus this patch will break things for them.

Hi,

how could this patch affect such projects at all?

If they are invoking wayland-scanner directly, nothing changes for them
as I can see, regardless whether they find wayland-scanner on their own
or use the $(wayland_scanner) used here.


Thanks,
pq

> If devs are OK with that (personally I'll say "yes please"), a big fat
> warning in the release notes & announcement is due.
> 
> Fwiw the patch is
> Reviewed-by: Emil Velikov <emli.velikov at collabora.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20170727/08eaa569/attachment-0001.sig>