[PATCH weston] dmabuf: Don't crash clients by sending version inappropriate events

Derek Foreman derekf at osg.samsung.com
Mon Jun 26 20:55:44 UTC 2017


We need to make sure the client bound dmabuf with a high enough
version to receive modifier events before sending them or the
client will crash.

Signed-off-by: Derek Foreman <derekf at osg.samsung.com>
---
 libweston/linux-dmabuf.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/libweston/linux-dmabuf.c b/libweston/linux-dmabuf.c
index ac219ac3..d81b63d5 100644
--- a/libweston/linux-dmabuf.c
+++ b/libweston/linux-dmabuf.c
@@ -483,6 +483,8 @@ bind_linux_dmabuf(struct wl_client *client,
 	wl_resource_set_implementation(resource, &linux_dmabuf_implementation,
 				       compositor, NULL);
 
+	if (version < ZWP_LINUX_DMABUF_V1_MODIFIER_SINCE_VERSION)
+		return;
 	/*
 	 * Use EGL_EXT_image_dma_buf_import_modifiers to query and advertise
 	 * format/modifier codes.
-- 
2.13.1



More information about the wayland-devel mailing list