[PATCH wayland-protocols v2 02/13] xdg-shell: Rename interfaces

Jonas Ådahl jadahl at gmail.com
Fri Jun 30 07:42:17 UTC 2017


On Fri, Jun 30, 2017 at 08:48:58AM +0200, Philipp Kerling wrote:
> Hi,
> 
> Am Freitag, den 30.06.2017, 13:50 +0800 schrieb Jonas Ådahl:
> > Rename the interfaces according to the wayland-protocols policy.
> > Since
> > the name 'xdg_shell' as an interface was already taken (by
> > xdg-shell-unstable-v5) zxdg_shell_v6 was renamed xdg_wm_base. The
> > surface role related interfaces were not renamed, as naming collision
> > is only unmanagable when exposed as globals via the registry.
> What about clients that want to support both xdg_shell (unstable v5)
> and xdg_wm_base? Won't they have a problem with
>    A. clashing type/function/macro names in the header files generated by
>       wayland-scanner, at least when they are including both headers in
>       one file?
>    B. clashing interface global names (e.g. "xdg_toplevel_interface") at
>       link time even when they do not include both headers at the same
>       time?

Right. This means you can't have xdg_shell_unstable_v5 at the same time
as xdg_wm_base, without messing around avoiding compiling and linking
issues.

Personally I'd rather not support v5 instead of coming up with new names
for everything; it *is* (was) an unstable protocol version and it has
always been expected that support for it will be removed. Do you know of
any client out in the wild that still only supports xdg_shell unstable
v5?


Jonas


> 
> Regards
> Philipp


More information about the wayland-devel mailing list