[PATCH wayland v2 1/4] wayland-util: do not export the wl_map_* API

Emil Velikov emil.l.velikov at gmail.com
Tue Mar 14 15:52:20 UTC 2017

On 14 March 2017 at 11:31, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Tue, 21 Feb 2017 16:14:26 +0000
> Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>> Used only internally and explicitly marked as such with commit
>> cf04b0a18f2 ("Move private definitions and prototypes to new
>> zwayland-private.h")
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>> ---
>>  src/wayland-util.c | 18 +++++++++---------
>>  1 file changed, 9 insertions(+), 9 deletions(-)
> Hi,
> R-b me and pushed:
>    9b78be6..654dee8  master -> master
> Let's see if anyone screams and forces us to revert. These have not
> been in public headers even in 1.0 release.
Thanks and let's hope we don't have to revert it.

> I verified with 'nm -g --defined-only' that this patch indeed does stop
> exporting the symbols.
I think you want `nm -CD --defined-only' here, since -g produces "no
symbols" even for libraries such as libGL.so.
Strictly speaking D is not needed, since it demangles any C++ symbols.

> I haven't looked at the other patches yet, this seemed like something
> to get in early in a release cycle.
> I still can't make my mind about the extra .so introduced in patch 3.
Anything I can do to sway you to the dark side ?
If Linux distribution is one of the core concerns I won't mind sending
them a patch or two.


More information about the wayland-devel mailing list