[PATCH wayland v2 2/4] wayland-util: split out private functionality to separate file
emil.l.velikov at gmail.com
Wed Mar 15 11:00:11 UTC 2017
On 14 March 2017 at 18:37, Yong Bakos <junk at humanoriented.com> wrote:
> Hi Emil,
>> On Feb 21, 2017, at 8:14 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> From: Emil Velikov <emil.velikov at collabora.com>
>> With next commit we'll make wayland-util a shared library (for reasons
>> mentioned in the commit). As such we need to make sure that the private
>> symbols are somewhere that they can be used internally. Otherwise we'll
>> end up with link errors.
>> v2: Rebase.
>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
> While others will certainly have to chime in and approve
> patches 2 - 4, the remainder of this series is
> Reviewed-by: Yong Bakos <ybakos at humanoriented.com>
> Tested-by: Yong Bakos <ybakos at humanoriented.com>
If people are OK with the idea, I'll re-spin 2-4 with r-b/other tags
and Eric's comment addressed...
>> --- a/src/wayland-util.c
>> +++ b/src/wayland-util.c
>> @@ -30,8 +30,8 @@
>> #include <string.h>
>> #include <stdarg.h>
>> -#include "wayland-util.h"
>> #include "wayland-private.h"
>> +#include "wayland-util.h"
... namely: this move is not needed. Silly git rebase on my end.
More information about the wayland-devel