[PATCH weston v2] libinput: Suppress unhandled-case warning

Peter Hutterer peter.hutterer at who-t.net
Thu Mar 16 22:52:37 UTC 2017


On Thu, Mar 16, 2017 at 10:01:05AM +0000, Daniel Stone wrote:
> When the wheel tilt source is present, gcc complains that we don't
> handle all possible enumeration values. We already ensure this cannot
> happen in its only caller (handle_pointer_axis), but gcc doesn't
> recognise this. Give it a default value to quiet the warning.
> 
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  libweston/libinput-device.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/libweston/libinput-device.c b/libweston/libinput-device.c
> index f97afcf8..fd4ad64a 100644
> --- a/libweston/libinput-device.c
> +++ b/libweston/libinput-device.c
> @@ -191,6 +191,8 @@ normalize_scroll(struct libinput_event_pointer *pointer_event,
>  		value = libinput_event_pointer_get_axis_value(pointer_event,
>  							      axis);
>  		break;
> +	default:
> +		assert(!"unhandled event source in normalize_scroll\n");

drop the '\n' because it's not an actual printf:
    test: test.c:4: main: Assertion `!"not meant to happen\n"' failed.

otherwise
Reviewed-by: Peter Hutterer <peter.hutterer at who-t.net>

Cheers,
   Peter

>  	}
>  
>  	return value;
> -- 
> 2.12.0


More information about the wayland-devel mailing list