[PATCH wayland] scanner: Reword fallthrough comment to quiet GCC
Daniel Stone
daniel at fooishbar.org
Fri Mar 17 17:57:49 UTC 2017
Hey Yong,
On 17 March 2017 at 17:55, Yong Bakos <junk at humanoriented.com> wrote:
> This mere comment change seems innocuous enough.
> (Should the standard `__attribute__ ((fallthrough))` be used instead?)
It could be good, but then we'd need autoconf bits to detect that and
come up with a macro for it ... seemed a bit overkill to be honest.
But if someone else wanted to do the legwork, I wouldn't complain!
(And would at least test it.)
Thanks for the review - I've pushed this now:
To ssh://git.freedesktop.org/git/wayland/wayland
9452cc53..3f2c1946 push -> master
Cheers,
Daniel
More information about the wayland-devel
mailing list