[PATCH weston 1/2] os: Check for EINTR on posix_fallocate()

Eric Engestrom eric.engestrom at imgtec.com
Thu Mar 23 17:42:39 UTC 2017


On Thursday, 2017-03-23 11:59:22 -0500, Derek Foreman wrote:
> posix_fallocate() can return EINTR and need to be restarted - I've hit
> this when running weston-terminal under gdb.
> 
> Signed-off-by: Derek Foreman <derekf at osg.samsung.com>

Both patches are:
Reviewed-by: Eric Engestrom <eric.engestrom at imgtec.com>

...and now I'm looking for these in $DAYJOB codebase ^^

> ---
>  shared/os-compatibility.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/shared/os-compatibility.c b/shared/os-compatibility.c
> index 551f2a99..6b2f3770 100644
> --- a/shared/os-compatibility.c
> +++ b/shared/os-compatibility.c
> @@ -178,7 +178,9 @@ os_create_anonymous_file(off_t size)
>  		return -1;
>  
>  #ifdef HAVE_POSIX_FALLOCATE
> -	ret = posix_fallocate(fd, 0, size);
> +	do {
> +		ret = posix_fallocate(fd, 0, size);
> +	} while (ret == EINTR);
>  	if (ret != 0) {
>  		close(fd);
>  		errno = ret;
> -- 
> 2.11.0
> 


More information about the wayland-devel mailing list