[RFC PATCH] xwm: Don't change focus on focus events from grabs

Daniel Stone daniel at fooishbar.org
Mon May 15 14:26:45 UTC 2017


Hi Olivier,

On 15 May 2017 at 12:32, Olivier Fourdan <ofourdan at redhat.com> wrote:
> xwm would not let X clients change the focus behind the compositor's
> back, reverting focus where it's supposed to be when this occurs.
>
> However, X11 grab also issue focus in events, on which some clients
> rely and reverting focus in this case braks the client logic (e.g.
> combobox menu in gtk+ using the X11 backend).
>
> Check if the focus event is actually coming from a grab or ungrab and
> do not revert focus in this case, to avoid breaking clients logic.

Thanks for tracking this down! Similarly to Pekka, about the best I
can offer is:
Acked-by: Daniel Stone <daniels at collabora.com>

However, given the general paucity of understanding of XWM, I think
pushing with these two acks is fine if we wait a week or so.

Cheers,
Daniel


More information about the wayland-devel mailing list