[RFC PATCH] xwm: Don't change focus on focus events from grabs

[Daniel Stone]

Hi,

On 15 May 2017 at 15:39, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Mon, 15 May 2017 15:26:45 +0100 Daniel Stone <daniel at fooishbar.org> wrote:
>> On 15 May 2017 at 12:32, Olivier Fourdan <ofourdan at redhat.com> wrote:
>> > xwm would not let X clients change the focus behind the compositor's
>> > back, reverting focus where it's supposed to be when this occurs.
>> >
>> > However, X11 grab also issue focus in events, on which some clients
>> > rely and reverting focus in this case braks the client logic (e.g.
>> > combobox menu in gtk+ using the X11 backend).
>> >
>> > Check if the focus event is actually coming from a grab or ungrab and
>> > do not revert focus in this case, to avoid breaking clients logic.
>>
>> Thanks for tracking this down! Similarly to Pekka, about the best I
>> can offer is:
>> Acked-by: Daniel Stone <daniels at collabora.com>
>>
>> However, given the general paucity of understanding of XWM, I think
>> pushing with these two acks is fine if we wait a week or so.
>
> mind that I am about disappear for two weeks by the end of this week.
> Quentin gave his Acked-by in irc.

Pushed now then with the three Acked-bys and your T-b. Thanks Olivier!

Cheers,
Daniel