[PATCH weston 3/3] weston-launch: improve help text for -u and -t

[Quentin Glidic]

On 11/1/17 3:24 PM, Pekka Paalanen wrote:
> From: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> 
> Explain that -u requires root and -t requires -u. Most importantly,
> document in what format does -t expect the tty to be given.
> 
> It has been confusing, because Weston's --tty option takes an integer,
> weston-launch takes a full device path.
> 
> Signed-off-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Seems good:
Reviewed-by: Quentin Glidic <sardemff7+git at sardemff7.net>

Thanks,


> ---
>   libweston/weston-launch.c | 6 ++++--
>   1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/libweston/weston-launch.c b/libweston/weston-launch.c
> index 6a7a7649..79a02506 100644
> --- a/libweston/weston-launch.c
> +++ b/libweston/weston-launch.c
> @@ -676,8 +676,10 @@ static void
>   help(const char *name)
>   {
>   	fprintf(stderr, "Usage: %s [args...] [-- [weston args..]]\n", name);
> -	fprintf(stderr, "  -u, --user      Start session as specified username\n");
> -	fprintf(stderr, "  -t, --tty       Start session on alternative tty\n");
> +	fprintf(stderr, "  -u, --user      Start session as specified username,\n"
> +			"                  e.g. -u joe, requires root.\n");
> +	fprintf(stderr, "  -t, --tty       Start session on alternative tty,\n"
> +			"                  e.g. -t /dev/tty4, requires -u option.\n");
>   	fprintf(stderr, "  -v, --verbose   Be verbose\n");
>   	fprintf(stderr, "  -h, --help      Display this help message\n");
>   }
> 


-- 

Quentin “Sardem FF7” Glidic