[PATCH v3 wayland] client: Allow absolute paths in WAYLAND_DISPLAY

[Pekka Paalanen]

On Sat, 18 Nov 2017 07:36:58 -0600
Matt Hoosier <matt.hoosier at gmail.com> wrote:

> On Fri, Nov 17, 2017 at 2:22 AM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> > On Tue, 14 Nov 2017 12:23:55 -0600
> > Matt Hoosier <matt.hoosier at gmail.com> wrote:
> >  
> >> From: Matt Hoosier <matt.hoosier at garmin.com>
> >>
> >> In order to support system compositor instances, it is necessary to
> >> allow clients' wl_display_connect() to find the compositor's listening
> >> socket somewhere outside of XDG_RUNTIME_DIR. For a full account, see
> >> the discussion beginning here:
> >>
> >> https://lists.freedesktop.org/archives/wayland-devel/2017-November/035664.html
> >>
> >> This change adjusts the client-side connection logic so that, if
> >> WAYLAND_DISPLAY is formatted as an absolute pathname, the socket
> >> connection attempt is made to just $WAYLAND_DISPLAY rather than
> >> usual user-private location $XDG_RUNTIME_DIR/$WAYLAND_DISPLAY.
> >>
> >> This change is based on Davide Bettio's submission of the same concept
> >> at:
> >>
> >> https://lists.freedesktop.org/archives/wayland-devel/2015-August/023838.html.
> >>
> >> v3 changes:
> >>
> >> * Added test case.
> >> * Clarified documentation to note that 'name' parameter to wl_display_connect()
> >>   can also be an absolute path.
> >>
> >> v2 changes:
> >>
> >> * Added backward incompatibility note to wl_display_connect() manpage.
> >> * Rephased wl_display_connect() manpage changes to precisely match actual
> >>   changed behavior.
> >> * Added mention of new absolute path behavior in wl_display_connect()
> >>   doxygen comments.
> >> * Mentioned new absolute path interpretation of WAYLAND_DISPLAY in
> >>   protocol documentation.
> >>
> >> Signed-off-by: Matt Hoosier <matt.hoosier at gmail.com>  
> >
> > Hi Matt,
> >
> > this patch looks very good. I have made some very small comments below,
> > but I'm confident that those fixed or discussed this patch will be:
> >
> > Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> >
> > Everyone else, especially those in the CC, I would like to ask you to
> > give your explicit Acked-by for this patch to record the community
> > acceptance in the git history.
> >
> > Matt, could you hold off sending v4 for a while so that you can collect
> > all the Reviewed-by's and Acked-by's that will arrive, but I am also
> > fine collecting them myself if you want this sooner out of your hands.  
> 
> Thanks, Pekka.
> 
> Yeah, I can wait a while to submit v4. I'll make the small changes you
> requested in your comments below, and add your r-b. I'm a little
> unclear on how I'll know when enough time has elapsed in your opinion
> to judge that all the ack's and r-b's that are likely to eventually
> arrive, have done so.

Hi Matt,

let's see what happens in a week.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20171120/23b80a59/attachment.sig>