[PATCH weston 01/12] shared: Add timespec_is_zero helper

[Pekka Paalanen]

On Fri, 24 Nov 2017 18:36:43 +0000
Emil Velikov <emil.l.velikov at gmail.com> wrote:

> Hi Alexandros,
> 
> On 16 November 2017 at 16:20, Alexandros Frantzis
> <alexandros.frantzis at collabora.com> wrote:
> 
> > +ZUC_TEST(timespec_test, timespec_is_zero)
> > +{
> > +       struct timespec zero = { 0 };
> > +       struct timespec non_zero_sec = { 1, 0 };
> > +       struct timespec non_zero_nsec = { 0, 1 };
> > +  
> The standard (be that POSIX or C99) does not guarantee the layout of
> the struct. Hence the above approach may work, but it's a bad idea.
> Personally I'm a fan of C99 designated initializers, although one
> could set the tv_sec and tv_nsec individually.
> 
> Same comment applies through the rest of the series.

That's actually a very good point, I missed it!

Alexandros, can you revise, please?


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20171127/0b08fd2f/attachment.sig>