[PATCH v3 wayland] client: Allow absolute paths in WAYLAND_DISPLAY

Matt Hoosier matt.hoosier at gmail.com
Mon Nov 27 15:00:23 UTC 2017


On Mon, Nov 27, 2017 at 3:16 AM, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Sat, 25 Nov 2017 08:11:43 -0600
> Matt Hoosier <matt.hoosier at gmail.com> wrote:
>
>> Hi Jonas, Pekka,
>>
>> I have no objection to making the tweaks that Jonas mentions, but I'm
>> wary of messing with the form of this patch that Pekka already
>> stamped. Pekka, am I going to lose your consent as given in v3 if I
>> make changes along the lines Jonas requests?
>
> Hi Matt,
>
> you can downgrade my Reviewed-by to Acked-by in this case. I think
> doing the changes Jonas suggested are good, but I cannot give R-b
> without seeing the actual words. I'll just re-review then.

Hi Pekka,

Thanks.

Jonas,

I've overhauled the manpage write-up to try to incorporate your
suggestions. I wasn't clear about how to interpret a couple of the
things you wrote, but I think your main thrust was to remove
wordiness, get rid of redundancy, and always call attention to the
compatibility notes. I've tried that, mostly be re-ordering things so
that the natural flow of the documentation on parameter interpretation
that was in-place before my change now survives. Now it just reads
like:

- *name* gives the socket to use (it's default value is wayland-0)
- $WAYLAND_DISPLAY replaces the default
- both *name* and $WAYLAND_DISPLAY are allowed to be absolute paths
- implication: if $WAYLAND_DISPLAY is absolute, then the connection
attempt will be too
- $WAYLAND_SOCKET overrides all of this, if it's set

-Matt


More information about the wayland-devel mailing list