[PATCH wayland] protocol: Suggest get_registry not be called frequently

Pekka Paalanen ppaalanen at gmail.com
Mon Oct 2 08:49:28 UTC 2017


On Fri, 29 Sep 2017 21:20:13 +0100
Daniel Stone <daniel at fooishbar.org> wrote:

> On 29 September 2017 at 19:46, Derek Foreman <derekf at osg.samsung.com> wrote:
> > I've heard some complaints that wl_display.get_registry "leaks"
> > server memory because wl_registry has no destructor.  While this isn't
> > strictly true - all those resources are freed when the client
> > disconnects - it's a bit of a gotcha for neophytes.
> >
> > Since wl_registry's version is not requested in any way through
> > wl_display.get_registry, we can't add a destructor request without
> > breaking ABI.  So let's be a little more clear about the result
> > of getting too many wl_registry objects.
> >
> > Signed-off-by: Derek Foreman <derekf at osg.samsung.com>  
> 
> Reviewed-by: Daniel Stone <daniels at collabora.com>

R-b me as well and pushed:
   5bb8268..f6bbc97  master -> master


Another downside of creating extra wl_registry objects is that when
globals are added and removed, the events are sent to all objects, dead
or alive in the client.


Thanks,
pq
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20171002/b4386b55/attachment.sig>


More information about the wayland-devel mailing list