[PATCH weston v12 11/40] compositor-drm: Don't restore original CRTC mode

Pekka Paalanen ppaalanen at gmail.com
Wed Oct 4 08:54:53 UTC 2017

On Tue, 26 Sep 2017 18:15:44 +0100
Daniel Stone <daniels at collabora.com> wrote:

> When leaving Weston, don't attempt to restore the previous CRTC
> settings. The framebuffer may well have disappeared, and in every
> likelihood, whoever gets the KMS device afterwards will be repainting
> anyway.
> Signed-off-by: Daniel Stone <daniels at collabora.com>
> ---
>  libweston/compositor-drm.c | 26 ++++++++------------------
>  1 file changed, 8 insertions(+), 18 deletions(-)

Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Random thoughts:

I suspect in the long run we will need to create a new struct for all
CRTCs to hold their properties, whether they have an output or not.

Hm, it's interesting... to set gamma, one needs to know the gamma table
size, for that one needs to have a CRTC allocated for the output, but
to allocate the CRTC one needs to atomic commit TEST_ONLY. Yeah, that's
for another era. Also dynamically switching the CRTC from under an
enabled output to accommodate enabling other outputs. All for when
atomic and head-based have long landed upstream already.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20171004/2013aed2/attachment.sig>

More information about the wayland-devel mailing list