[PATCH weston] gl-renderer: Ignore INVALID modifier

Daniel Stone daniel at fooishbar.org
Thu Oct 5 09:21:24 UTC 2017


On 5 October 2017 at 08:15, Pekka Paalanen <ppaalanen at gmail.com> wrote:
> On Wed,  4 Oct 2017 18:35:45 +0100
> Daniel Stone <daniels at collabora.com> wrote:
>> If the user has passed an INVALID modifier, it's because there is no
>> applicable modifier, and the buffer layout should be determined by a
>> magic side-channel call (e.g. bo_get_tiling). If the modifier is
>> INVALID, don't try to pass it through to EGL, but just drop it.
>>
>> On the other hand, if a modifier _is_ explicitly specified and we don't
>> have the modifiers extension, then refuse to import the buffer.
>
> gl_renderer_import_dmabuf() guarantees that all modifiers are equal,
> hence checking only one is enough.
>
> Reviewed-by: Pekka Paalanen <pekka.paalanen at collabora.co.uk>

Thanks Pekka! Pushed now.

Cheers,
Daniel


More information about the wayland-devel mailing list