[PATCH wayland-protocols v3] protocol: add compositor-debug.xml

Mon Oct 9 09:50:28 UTC 2017

On Mon, 9 Oct 2017 09:38:31 +0000
"Maniraj Devadoss (RBEI/ECF3)" <Maniraj.Devadoss at in.bosch.com> wrote:

> Hello Pekka,
> 
> As Emre updated already, I moved to India last week and my mail-id is
> also changed. Currently I am preparing my working setup. Once it is
> completed I will modify and upstream the patches.

Hi Maniraj,

thank you for the notice.

I discussed about the .pc files on #wayland a bit, and I believe the
safest way forward is to create a new libweston-$MAJOR-protocols.pc
file and install that for external projects to find the XML files
installed by libweston. The contents of that file should follow the
pattern of wayland-protocols.pc but the XML file directory is of course
different.

Thanks,
pq

> -----Original Message-----
> From: wayland-devel
> [mailto:wayland-devel-bounces at lists.freedesktop.org] On Behalf Of
> Pekka Paalanen Sent: Wednesday, October 04, 2017 7:50 PM To: Jonas
> Ådahl <jadahl at gmail.com>; Maniraj Devadoss
> <external.mdevadoss at de.adit-jv.com> Cc:
> wayland-devel at lists.freedesktop.org Subject: Re: [PATCH
> wayland-protocols v3] protocol: add compositor-debug.xml
> 
> On Wed, 4 Oct 2017 10:07:30 -0400
> Jonas Ådahl <jadahl at gmail.com> wrote:
> 
> > On Tue, Oct 03, 2017 at 11:45:41AM +0300, Pekka Paalanen wrote:  
> > > On Fri, 22 Sep 2017 11:17:49 +0200
> > > Maniraj Devadoss <external.mdevadoss at de.adit-jv.com> wrote:
> > >     
> > > > From: Pekka Paalanen <pq at iki.fi>
> > > > 
> > > > This is a new debugging extension for non-production
> > > > environments. The aim is to replace all build-time choosable
> > > > debug prints in the compositor with runtime subscribable debug
> > > > streams.
> > > > 
> > > > Signed-off-by: Pekka Paalanen <pq at iki.fi>
> > > > Signed-off-by: Maniraj Devadoss
> > > > <external.mdevadoss at de.adit-jv.com> ---
> > > >  Makefile.am                                        |   1 +
> > > >  unstable/compositor-debug/README                   |   7 ++
> > > >  .../compositor-debug-unstable-v1.xml               | 128
> > > > +++++++++++++++++++++ 3 files changed, 136 insertions(+)
> > > >  create mode 100644 unstable/compositor-debug/README
> > > >  create mode 100644
> > > > unstable/compositor-debug/compositor-debug-unstable-v1.xml
> > > > 
> > > > diff --git a/Makefile.am b/Makefile.am
> > > > index 5b5ae96..a0994d1 100644
> > > > --- a/Makefile.am
> > > > +++ b/Makefile.am
> > > > @@ -15,6 +15,7 @@ unstable_protocols
> > > > =
> > > > \
> > > > unstable/xwayland-keyboard-grab/xwayland-keyboard-grab-unstable-v1.xml
> > > > \
> > > > unstable/keyboard-shortcuts-inhibit/keyboard-shortcuts-inhibit-unstable-v1.xml
> > > > \
> > > > unstable/xdg-output/xdg-output-unstable-v1.xml
> > > > \
> > > > +
> > > > unstable/compositor-debug/compositor-debug-unstable-v1.xml
> > > > \ $(NULL) 
> > > >  stable_protocols
> > > > =
> > > > \ diff --git a/unstable/compositor-debug/README
> > > > b/unstable/compositor-debug/README new file mode 100644 index
> > > > 0000000..f1a7603 --- /dev/null
> > > > +++ b/unstable/compositor-debug/README
> > > > @@ -0,0 +1,7 @@
> > > > +Compositor Debug protocol
> > > > +
> > > > +Maintainers:
> > > > +Pekka Paalanen <pekka.paalanen at collabora.co.uk>
> > > > +Friedrich Eugen <efriedrich at de.adit-jv.com>
> > > > +Ucan Emre <eucan at de.adit-jv.com>
> > > > +Maniraj Devadoss <maniraj.devadoss at in.bosch.com>
> > > > diff --git
> > > > a/unstable/compositor-debug/compositor-debug-unstable-v1.xml
> > > > b/unstable/compositor-debug/compositor-debug-unstable-v1.xml
> > > > new file mode 100644 index 0000000..b81c630 --- /dev/null
> > > > +++ b/unstable/compositor-debug/compositor-debug-unstable-v1.xml
> > > > @@ -0,0 +1,128 @@
> > > > +<?xml version="1.0" encoding="UTF-8"?>
> > > > +<protocol name="compositor_debug_unstable_v1">
> > > > +
> > > > +  <copyright>
> > > > +    Copyright © 2017 Pekka Paalanen pq at iki.fi    
> > > 
> > > Hi Maniraj,
> > > 
> > > it wasn't necessary to "obfuscate" the email addresses, we don't
> > > tend to do that. Anyway, this patch is fine by me.
> > > 
> > > Jonas, would you like to give an Acked-by and maybe cut a
> > > wayland-protocols release so we have a version number for Weston
> > > to depend on? Or if you have anything you'd like changed?    
> > 
> > For me this is out of scope for wayland-protocols. The idea behind
> > wayland-protocols is to have a place for protocols that can/should
> > be used between any compositor and "normal" client. So far (and my
> > opinion is that it will continue to be so) this has meant that
> > things like debug protocols (like the infamous "wl_randr" protocol)
> > and desktop environment components (like a generic "panel"
> > protocol) have been out of scope.
> > 
> > They may not be out of scope for Wayland as a whole (for example
> > wayland-wall tries to fill the hole regarding DE environment
> > components). I discussed this with Pekka on IRC, and for this
> > particular protocol, I think it makes more sense to keep it a
> > weston extension. Weston can however install the XML file and third
> > party clients and compositors can depend on it in any way they want.
> >   
> 
> Thank you Jonas, I perfectly understand that point of view.
> 
> Maniraj, we need to go back to the weston-specific naming for both
> interfaces and the XML file name. You could arrange libweston to
> install the XML file under $datadir/weston/protocols/. We also need a
> way to get the path from pkg-config. I would have just added a
> variable to libweston-$MAJOR.pc but I'm not sure that's good for
> arch-independent data. That would allow external projects to use the
> protocol extension.
> 
> 
> Thanks,
> pq

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20171009/8a38542c/attachment.sig>