[PATCH wayland v2 6/8] build: wire-up wayland-egl

[Quentin Glidic]

On 10/10/17 5:21 PM, Emil Velikov wrote:
> On 10 October 2017 at 15:19, Quentin Glidic
> <sardemff7+wayland at sardemff7.net> wrote:
>> On 10/10/17 3:43 PM, Emil Velikov wrote:
>>>
>>> From: Emil Velikov <emil.velikov at collabora.com>
>>>
>>> Wire-up the imported sources, test and pkg-config files.
>>>
>>> v2:
>>>    - Don't mangle with existing EXTRA_DIST list
>>>    - Add the symbols check script to the `make check' target
>>>    - Rename wayland-egl-{priv,backend}.h
>>>
>>> Signed-off-by: Emil Velikov <emil.velikov at collabora.com>
>>> ---
>>>    Makefile.am  | 22 ++++++++++++++++++++--
>>>    configure.ac |  2 ++
>>>    2 files changed, 22 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/Makefile.am b/Makefile.am
>>> index 0eedb10..eba9e81 100644
>>> --- a/Makefile.am
>>> +++ b/Makefile.am
>>> @@ -118,6 +118,7 @@ BUILT_SOURCES =                                     \
>>>      CLEANFILES = $(BUILT_SOURCES) doc/doxygen/doxygen_sqlite3.db
>>>    DISTCLEANFILES = src/wayland-version.h
>>> +EXTRA_DIST =
>>>        @@ -142,6 +143,16 @@ libwayland_cursor_la_CFLAGS =
>>> \
>>>          -I$(top_srcdir)/src                     \
>>>          -DICONDIR=\"$(ICONDIR)\"
>>>    +lib_LTLIBRARIES += libwayland-egl.la
>>> +
>>> +libwayland_egl_la_SOURCES = egl/wayland-egl.c
>>> +libwayland_egl_la_LDFLAGS = -version-info 1
>>> +
>>> +pkgconfig_DATA += egl/wayland-egl.pc
>>> +
>>> +## XXX: backend interface
>>> +include_HEADERS += egl/wayland-egl-backend.h
>>> +pkgconfig_DATA += egl/wayland-egl-backend.pc
>>>      built_test_programs =                               \
>>>          array-test                              \
>>> @@ -163,7 +174,13 @@ built_test_programs =                              \
>>>          message-test                            \
>>>          headers-test                            \
>>>          compositor-introspection-test           \
>>> -       protocol-logger-test
>>> +       protocol-logger-test                    \
>>> +       wayland-egl-abi-check
>>> +
>>> +EXTRA_DIST += egl/wayland-egl-symbols-check
>>
>>
>> Nit: dist_check_SCRIPTS
>>
> Existing code uses EXTRA_DIST. Can we update everything as a follow-up?

A follow-up to fix existing uses would be nice, but not introducing more 
stuff to fix is good too :-)

In this regard, you can even put "dist_check_SCRIPTS =" in your patch 
(to avoid moving the initial declaration around like you had to do with 
EXTRA_DIST).

-- 

Quentin “Sardem FF7” Glidic