[PATCH weston v3] compositor-wayland: Don't use two different presentation methods for fs shell

Pekka Paalanen ppaalanen at gmail.com
Fri Oct 13 12:37:23 UTC 2017

On Tue,  7 Feb 2017 21:03:40 +0100
Armin Krezović <krezovic.armin at gmail.com> wrote:

> This patch fixes the wayland backend to not use two different
> presentation methods when running on fullscreen-shell.
> See also: https://patchwork.freedesktop.org/patch/114534/
> v2:
>  - Add missing wayland_output_resize_surface() call
>  - Start repaint loop after initial frame has been drawn
> v3:
>  - Redraw the initial frame if present for mode fails
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=93514
> Signed-off-by: Armin Krezović <krezovic.armin at gmail.com>
> ---
>  libweston/compositor-wayland.c | 90 ++++++++++++++++++++++++------------------
>  1 file changed, 51 insertions(+), 39 deletions(-)


the switch_mode path looks highly suspicious to me, but I'm not going
to nag about it as we have very few and rare ways to trigger it. It
also was like that before this patch already.

Launching it with --sprawl hits a corrupted output->mode_list in
bind_output(), but that happens also without this patch.

wayland_output_set_fullscreen() has a hopefully stale fshell path,
since 'method' is for wl_shell.

This patch is still definitely an improvement. Pushed:
   b4e239f2..71ebc052  master -> master

As part of my clone mode work, I will probably need to refactor the
wayland backend quite a bit to accommodate the head-based API.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 833 bytes
Desc: OpenPGP digital signature
URL: <https://lists.freedesktop.org/archives/wayland-devel/attachments/20171013/6ce66532/attachment.sig>

More information about the wayland-devel mailing list